typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt
Other
29 stars 22 forks source link

Play conductr libs should support auto-downing #269

Closed bayarmunkh closed 7 years ago

bayarmunkh commented 7 years ago

Hi,

When SBR downs a play app/node, it stays hanging, requires manual stopping. So you have to implement a handler for registerOnMemberRemoved callback in order to the play app follow SBR's decision. I think the play conductr libs should support this out of box. Also including a handler for registerOnMemberUp would be a good idea too.

Thanks

huntc commented 7 years ago

Thanks Chka. Moving it over here: https://github.com/typesafehub/conductr-lib/issues/146 - please follow the issue there. I'll close this issue as sbt-conductr and conductr-lib are different.

bayarmunkh commented 7 years ago

ah, right. what was i thinking. thanks!