Add tests for LagomApplicationLoader.describeService

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt

Other

29 stars 22 forks source link

Closed TimMoore closed 7 years ago

TimMoore commented 7 years ago

Fixes #273

The first commit contains only tests for the deprecated API, which should succeed.

I expect subsequent commits to fail until Lagom 1.3.6 is released. I'm opening a WIP pull request so this can be verified against Travis.

I'll advise when this is ready to merge.

TimMoore commented 7 years ago

I've confirmed with a local build of 1.3.6-SNAPSHOT that it fixes these tests. So this will stay on hold pending the 1.3.6 release.

TimMoore commented 7 years ago

Picking this up again today, now that 1.3.6 is out.

TimMoore commented 7 years ago

I think this is ready now. Build is green.

markusjura commented 7 years ago

LGTM (already approved the PR)