Refactoring the plugin to use single task

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt

Other

29 stars 22 forks source link

Refactoring the plugin to use single task #63

Closed eed3si9n closed 9 years ago

eed3si9n commented 9 years ago

Fixes #58

Mostly followed the plugins best practices.

Adds input task condurctr, which replaces existing load, start, etc.
Moves out functionality to plain old Scala object TypesafeConductR
Adds required plugins SbtNativePackager && UniversalPlugin && JavaAppPackaging (Is this enough?)

/review @jsuereth, @huntc

hseeberger commented 9 years ago

Nice work!

@huntc, can we use this to rename TypesafeConductR to ConductR?

huntc commented 9 years ago

Thanks @eed3si9n!

Yes, let's drop the "Typesafe" prefix. I now agree that this was overkill.

Also let's name the "conductr" task just "conduct" as per the Python CLI.

Heiko there are some style things including using final vals. Small stuff. Could you please review? :-)

hseeberger commented 9 years ago

@huntc, I suggest we don't bother Eugene with our specific style guide and instead create an issue and handle renaming and style issues ourselves. WDYT?

huntc commented 9 years ago

Sure, whatever works.