AST tightening: `PrivateIdentifier` can only be LHS of `BinaryExpression[operator='in']`

typescript-eslint / typescript-eslint

:sparkles: Monorepo for all the tooling which enables ESLint to support TypeScript

https://typescript-eslint.io

Other

14.87k stars 2.67k forks source link

Open Josh-Cena opened 3 weeks ago

Josh-Cena commented 3 weeks ago

We are planning to enforce the following invariants in our AST for BinaryExpression:

left can only be a PrivateIdentifier if operator: "in", so the following is a parsing error:
```
#a + 1;
```

@sosukesuzuki @fisker Do these look safe to you?

fisker commented 3 weeks ago

Looks good.