Fixes - Githubissues

typescript-ruby / typescript-rails

An asset pipeline wrapper for the TypeScript language

MIT License

255 stars 30 forks source link

Fixes #16

Closed lorddoig closed 9 years ago

lorddoig commented 9 years ago

Fixes a bug in replace_relative_references that was adding \n\n for every \n in the original source, which in turn was causing line numbers displayed in errors to be meaningless.
Make errors show the path to the asset file as opposed to the compilers tempfile. This is a kludge, but it works.
No new tests, but no failing tests.

coveralls commented 9 years ago

Coverage decreased (-3.82%) when pulling 48efd8ce0ae343c2e4743344986d7e5226a6698d on lorddoig:fixes into a07bef94d499c66d97b191a78bf88cb325d40bfd on typescript-ruby:master.

lorddoig commented 9 years ago

The newline solution in #15 is more efficient, just noticed that.

coveralls commented 9 years ago

Coverage decreased (-3.94%) when pulling 6576ca14dbd14051443f99b15ed248de2a8fcec1 on lorddoig:fixes into a07bef94d499c66d97b191a78bf88cb325d40bfd on typescript-ruby:master.

gfx commented 9 years ago

I'm sorry to be late. I have merged #15. Is this pull-request still effective?