search

typesense / docusaurus-theme-search-typesense

A fork of the awesome @docusaurus/theme-search-algolia library customized to work with Typesense
https://typesense.org/docs/guide/docsearch.html
MIT License
67 stars 15 forks source link

Support for Docusaurus 3.4.0 #46

Closed timolagus closed 5 months ago

timolagus commented 5 months ago

Description

Add support for Docusaurus 3.4.0.

Steps to reproduce

Update to the following dependency versions in package.json:

@docusaurus/core: 3.4.0
@docusaurus/module-type-aliases: 3.4.0
@docusaurus/preset-classic: 3.4.0
@docusaurus/theme-live-codeblock: ^3.4.0
@docusaurus/theme-mermaid: ^3.4.0
@docusaurus/types: 3.4.0

Expected Behavior

npm install completes without issue.

Actual Behavior

npm install fails with:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: docusaurus-theme-search-typesense@0.19.0
npm ERR! Found: @docusaurus/core@3.4.0
npm ERR! node_modules/@docusaurus/core
npm ERR!   @docusaurus/core@"3.4.0" from the root project
npm ERR!   @docusaurus/core@"3.4.0" from @docusaurus/plugin-debug@3.4.0
npm ERR!   node_modules/@docusaurus/plugin-debug
npm ERR!     @docusaurus/plugin-debug@"3.4.0" from @docusaurus/preset-classic@3.4.0
npm ERR!     node_modules/@docusaurus/preset-classic
npm ERR!       @docusaurus/preset-classic@"3.4.0" from the root project
npm ERR!   24 more (@docusaurus/plugin-google-analytics, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @docusaurus/core@"3.3.2" from docusaurus-theme-search-typesense@0.19.0
npm ERR! node_modules/docusaurus-theme-search-typesense
npm ERR!   docusaurus-theme-search-typesense@"^0.19.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @docusaurus/core@3.3.2
npm ERR! node_modules/@docusaurus/core
npm ERR!   peer @docusaurus/core@"3.3.2" from docusaurus-theme-search-typesense@0.19.0
npm ERR!   node_modules/docusaurus-theme-search-typesense
npm ERR!     docusaurus-theme-search-typesense@"^0.19.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Metadata

Typesense Version: 0.25.1

OS: Ubuntu 22.04.4 LTS

jasonbosco commented 5 months ago

Just published 0.20.0-0. Could you give it a shot and let me know how it goes?

timolagus commented 5 months ago

Tested. Docusaurus builds OK and search works normally. ✅

Thank you, @jasonbosco!

jasonbosco commented 5 months ago

Thank you for confirming. Just published 0.20.0.