search

typesense / docusaurus-theme-search-typesense

A fork of the awesome @docusaurus/theme-search-algolia library customized to work with Typesense
https://typesense.org/docs/guide/docsearch.html
MIT License
67 stars 15 forks source link

`yarn build` throws build errors after merging in #56 #57

Closed jasonbosco closed 1 week ago

jasonbosco commented 2 weeks ago

Description

Running yarn build throws build errors after merging in #56

Steps to reproduce

$ yarn build
yarn run v1.22.19
$ tsc --build && node copyUntypedFiles.mjs && prettier --config .prettierrc --write "src/**/*.{js,ts,tsx,css}"
tsconfig.client.json:57:15 - error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.

57     "module": "esnext",
                 ~~~~~~~~

Found 1 error.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Metadata

Node 18, macOS

jasonbosco commented 2 weeks ago

cc: @tharropoulos

tharropoulos commented 1 week ago

This wasn't a regression, this was present before! This will only throw when emitting with tsc and subsequently the compiler will fail because of the module / resolution mismatch looking at the docusaurus tsconfig, we should use NodeNext as the module setting. Will post up a PR for this