typesense / firestore-typesense-search

Firebase Extension to automatically push Firestore documents to Typesense for full-text search with typo tolerance, faceting, and more
https://extensions.dev/extensions/typesense/firestore-typesense-search
Apache License 2.0
159 stars 35 forks source link

return value.path when value == DocumentReference #35

Closed Guilledorfman closed 2 years ago

Guilledorfman commented 2 years ago

Change Summary

PR Checklist

jasonbosco commented 2 years ago

Thank you for the PR @Guilledorfman. I've made some small tweaks and tested it locally, it works like we discussed.

I need to do some non-trivial changes to get the tests to work in CI again with the latest changes to firebase-cli. So I'll merge this PR in and then do changes needed for CI separately.

I'll keep you posted when I've published the changes in this PR in a new version of the extension.

jasonbosco commented 2 years ago

Related to #34