typesense / laravel-scout-typesense-driver

Laravel Scout Driver for Typesense
https://typesense.org
MIT License
131 stars 38 forks source link

Fixes preparation of filters and revert breaking changes #50

Closed michgeek closed 1 year ago

michgeek commented 1 year ago

Change Summary

Concerning issue #43

It takes care of the following cases :

$whereFilter = 'a';
$whereInFilter = 'b';
// Expected 'a && b'

$whereFilter = 'a';
$whereInFilter = '';
// Expected 'a'

$whereFilter = '';
$whereInFilter = 'b';
// Expected 'b'

$whereFilter = '';
$whereInFilter = '';
// Expected ''

PR Checklist

karakhanyans commented 1 year ago

Hi @michgeek #47 was merged. I will close this PR for now and we can add filters back later. Thank you.