Closed joostdecock closed 1 year ago
Thank you for the PR @joostdecock!
I'd prefer for the text you've added to the README to be alongside the rest of the documentation, so it's all in one place.
Could you cut/paste it at the bottom of this page: https://typesense.org/docs/guide/docsearch.html (You'll find an edit button at the bottom of the page).
@jasonbosco sure thing:
@joostdecock Thank you! I've published your updates in typesense/docsearch-scraper:0.7.0.rc1
. Could you give it a shot and confirm that it works as expected?
@jasonbosco it seems to be missing the dependency:
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/seleuser/src/index.py", line 8, in <module>
from keycloak.realm import KeycloakRealm
ModuleNotFoundError: No module named 'keycloak'
Oops, I missed a build step. Could you try again with typesense/docsearch-scraper:0.7.0.rc2
?
@jasonbosco Sorry for the delay, I had some unexpected health issues, but the dependency issue is fixed in rc2
👍
Thank you for confirming @joostdecock. I just published typesense/docsearch-scraper:0.7.0
.
Hope you're feeling better now.
Change Summary
This adds support for Keycloak SSO, which closes #39
I have also added an extra section to the README with info that I found was (too) hard to find:
If that is unwanted, I can re-submit without the README changes.
PR Checklist