search

typesense / typesense-docsearch-scraper

A fork of Algolia's awesome DocSearch Scraper, customized to index data in Typesense (an open source alternative to Algolia)
https://typesense.org/docs/guide/docsearch.html
Other
95 stars 35 forks source link

Provide multi-arch docker image #57

Open darkweaver87 opened 4 months ago

darkweaver87 commented 4 months ago

Description

Scraper is currently not working on ARM architecture for instance.

Steps to reproduce

Run it on an ARM machine, you will get an exec format error.

Expected Behavior

Run it as it runs on X86.

Actual Behavior

Doesn't run. I'll be happy to help on that topic but I didn't find any CI job I can modify which actually produces the docker image ... I understand that selenium can't be installed on ARM but do you think to some alternatives ?

Metadata

Typesense Version: 0.25.2

OS: any OS running containerd/dockerd

jasonbosco commented 4 months ago

A PR to make it multi-arch would be great.

I follow the steps in this section of the README to release a new version: https://github.com/typesense/typesense-docsearch-scraper?tab=readme-ov-file#releasing-a-new-version

darkweaver87 commented 4 months ago

OK thanks, I wanted to check if there were any kind of CI job for releasing. I'll open a PR then :-)

immanuelfodor commented 4 months ago

Fixed by https://github.com/typesense/typesense-docsearch-scraper/pull/58