typesense / typesense-docsearch-scraper

A fork of Algolia's awesome DocSearch Scraper, customized to index data in Typesense (an open source alternative to Algolia)
https://typesense.org/docs/guide/docsearch.html
Other
105 stars 37 forks source link

feat: add support for http_auth_domain spider attribute #67

Closed nkls-so closed 2 months ago

nkls-so commented 2 months ago

See https://doc.scrapy.org/en/latest/topics/downloader-middleware.html#module-scrapy.downloadermiddlewares.httpauth

Change Summary

Add the option to define the domain which requires the http authentication.

In previous Scrapy versions HttpAuthMiddleware sent the authentication data with all requests, which is a security problem if the spider makes requests to several different domains. Currently if the http_auth_domain attribute is not set, the middleware will use the domain of the first request, which will work for some spiders but not for others. In the future the middleware will produce an error instead.

jasonbosco commented 2 months ago

Thanks @nkls-so!

jasonbosco commented 2 months ago

This is now available in v0.10.0