typesense / typesense-go

Go client for Typesense: https://github.com/typesense/typesense
Apache License 2.0
220 stars 56 forks source link

Search param `split_join_tokens` is not supported #111

Closed cmigazzi closed 2 years ago

cmigazzi commented 2 years ago

Description

The query param split_join_tokens is not supported by SearchCollectionParams. I've checked the struct and haven't found the param definition.

Steps to reproduce

Try to create search collection params with SplitJoinTokens:

searchParameters := &api.SearchCollectionParams{
    Q:               "test",
    QueryBy:         "keywords",
    SplitJoinTokens: "always",
}

Expected Behavior

No error and being able to use split_join_tokens as specified in Typesense documentation

Actual Behavior

Trigger an error: unknown field 'SplitJoinTokens' in struct literal of type api.SearchCollectionParams

Metadata

Typsense Version: 0.23.0

cmigazzi commented 2 years ago

I've just opened a PR to add these parameters: https://github.com/typesense/typesense-api-spec/pull/29

kishorenc commented 2 years ago

Thanks, I've merged that PR and have generated updated client code and published it as v0.6.0.