Functions don't take a `context.Context`

typesense / typesense-go

Go client for Typesense: https://github.com/typesense/typesense

Apache License 2.0

208 stars 55 forks source link

Functions don't take a `context.Context` #143

Closed Hades32 closed 8 months ago

Hades32 commented 1 year ago

This is best practice in Go for all IO functions to ensure proper timeout handling. This library just uses context.Background() internally, which is really bad

vamshiaruru32 commented 1 year ago

+1 for this