search

typesense / typesense-go

Go client for Typesense: https://github.com/typesense/typesense
Apache License 2.0
208 stars 55 forks source link

github.com/typesense/typesense-go/v2/go.mod does not exist #162

Closed dahvlhldle closed 3 months ago

dahvlhldle commented 3 months ago

github.com/typesense/typesense-go/v2/go.mod does not exist

mynlexi commented 3 months ago

same here cant upgrade

https://pkg.go.dev/github.com/typesense/typesense-go/typesense (still on 1.0.0)

kishorenc commented 3 months ago

Somehow pkg.go.dev is not picking up the latest release: https://github.com/typesense/typesense-go/releases/tag/v2.0.0

leetm4n commented 3 months ago

by go module standard, because you bumped to v2 it should be under repo/v2/ and adding a v2 gomod file there, while you could keep the v1 in the root

leetm4n commented 3 months ago

or you could do what e.g. labstack/echo did: https://github.com/labstack/echo/blob/master/go.mod

they just have v4 in the root gomod, but sadly you cannot tag v2 without you updating to v2 gomod

cysp commented 3 months ago

Looking at the changes in v2, are they actually a semver-major change? The phrasing in the upgrade notes sounds like the added generic types are an optional feature rather than a source-breaking one. It seems like the simplest solution would be to release that as an update in the v1 release line rather than bumping the major version, given all of this rigmarole with changing import paths. Would that be an option?

kishorenc commented 3 months ago

Given that there were no breaking changes, I've published v1.1.0 instead and deleted the earlier v2 release.