search

typesense / typesense-js

JavaScript / TypeScript client for Typesense
https://typesense.org/docs/api
Apache License 2.0
414 stars 75 forks source link

make SearchParams['query_by'] adhere to spec #121

Closed olve closed 2 years ago

olve commented 2 years ago

docs allow string arrays for SearchParams['query_by'], but provided typescript definitions don't.

I'm not signing anything, but this would fix #120.

Unless i misunderstood entirely, and the query-field is supposed to contain pre-formatted strings eg. "['name', 'email']".

jasonbosco commented 2 years ago

See here: https://github.com/typesense/typesense-js/issues/120#issuecomment-1142398318