search

typesense / typesense-js

JavaScript / TypeScript client for Typesense
https://typesense.org/docs/api
Apache License 2.0
393 stars 74 forks source link

Update Key.d.ts to fix build #167

Closed nikhilag closed 1 year ago

nikhilag commented 1 year ago

Change Summary

I ran into a build issue on using latest typesense library because of the typescript issue in Key.d.ts file.

PR Checklist

jasonbosco commented 1 year ago

Hmm wonder how Typescript compilation didn't catch that.

Thank you for the PR!

jasonbosco commented 1 year ago

Oh wait, this change is in the compiled JS code in the /lib folder which will get overridden on build. So this needs to be added in the corresponding .ts file in src.

Could you update the PR?

nikhilag commented 1 year ago

Oh wait, this change is in the compiled JS code in the /lib folder which will get overridden on build. So this needs to be added in the corresponding .ts file in src.

Could you update the PR?

Yes doing this now

nikhilag commented 1 year ago

@jasonbosco It seems value_prefix?: string; was missing from Key.ts file under src. I have now added it there. Please check if this works. Locally building the code is adding more changes and so I have done these changes in github directly.

jasonbosco commented 1 year ago

Just published this in v1.7.1. Thanks @nikhilag!