search

typesense / typesense-js

JavaScript / TypeScript client for Typesense
https://typesense.org/docs/api
Apache License 2.0
393 stars 74 forks source link

Improve TypeScript compatibility #183

Open felixh10r opened 9 months ago

felixh10r commented 9 months ago

Description

When using TypeScript > 5.1, there are numerous type check errors, most of which are related to Element implicitly has an 'any' type because expression of type 'string' can't be used to index type (…), but also Parameter (…) implicitly has an 'any' type.. My tsconfig.json already includes "skipLibCheck": true so there is not a lot I can do to work around besides pinning the TS version.

Steps to reproduce

Include typesense in a JS project and e.g. import type { SearchResponse } from "typesense/lib/Typesense/Documents";. Run tsc >= 5.2.

Expected Behavior

The project compiles without any issues.

Actual Behavior

There are a lot of typescript issues, probably depending on how much typesense interfaces are imported.

Metadata

Typesense Version: 1.7.2

OS: MacOS 14.1.1 Node 21.2.0

berenddeboer commented 8 months ago

Yeah, just started using this, and it's unusable in typescript because of the errors. At least for me, Trying to figure out how I can ignore typechecks on this library only.