[Cloudflare] Fix the 'credentials' field on 'RequestInitializerDict' is not implemented

typesense / typesense-js

JavaScript / TypeScript client for Typesense

https://typesense.org/docs/api

Apache License 2.0

414 stars 75 forks source link

[Cloudflare] Fix the 'credentials' field on 'RequestInitializerDict' is not implemented #220

Closed cungminh2710 closed 2 months ago

cungminh2710 commented 2 months ago

Change Summary

credential field is set by default, which is causing issue when running with cloudflare worker

We explicitly set "credentials" as undefined if it's not supported

PR Checklist

[x] I have read and signed the Contributor License Agreement.

jasonbosco commented 2 months ago

@cungminh2710 Shouldn't this fix ideally be inside of axios, instead of inside typesense-js? I also see that the PR you linked to has been merged, so is it already fixed in axios?