typesense / typesense-js

JavaScript / TypeScript client for Typesense
https://typesense.org/docs/api
Apache License 2.0
414 stars 75 forks source link

`SearchResponseHit.highlights` and `SearchResponseFacetCountSchema.counts` has invalid type definitions. #91

Closed tugaykaracay closed 2 years ago

tugaykaracay commented 2 years ago

Description

SearchResponseHit.highlights and SearchResponseFacetCountSchema.counts has invalid type definitions. They should be in array format.

Metadata

Typsense Version: 1.0.3-4

nandorojo commented 2 years ago

Here is a fix #129

jasonbosco commented 2 years ago

Thank you @nandorojo! I've published this in v1.4.0-4.

nandorojo commented 2 years ago

Sure thing!

It would be nice to have docs for facet_counts by the way.

jasonbosco commented 2 years ago

Faceting is covered briefly here: https://typesense.org/docs/0.23.1/api/search.html#facet-results

Were you looking for something else?