search

typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI
Apache License 2.0
21 stars 16 forks source link

Fix missing `py.typed` files #109

Closed Avasam closed 10 months ago

Avasam commented 11 months ago

Fixes #108

We were accidentally copying typeshed/stubs/entry-stubs to dist/entry-stubs-stubs instead of dist/entry-stubs

srittau commented 10 months ago

This change seems fine, although I'm unsure how this fixes #108?

Avasam commented 10 months ago

This change seems fine, although I'm unsure how this fixes #108?

We were copying the py.typed marker file to the wrong location. So it wasn't included in the distribution.

I ran tests locally to 1. see and understand the issue and 2. Ensure this change copies the file to the right location.

JelleZijlstra commented 10 months ago

Does this mean that some of our uploaded stub packages are missing this file? Should we force a new release for those?

AlexWaygood commented 10 months ago

Stubs packages generally don't need py.typed files. We only started adding them recently to typeshed's packages because we wanted to explicitly mark some of them as partial. So it means the new feature has been broken up till now, but hopefully it'll work from this point onwards

Avasam commented 10 months ago

Does this mean that some of our uploaded stub packages are missing this file? Should we force a new release for those?

The 40 stubs with partial_stub = true in METADATA.toml would be affected. But as @AlexWaygood just mentioned, it wasn't a regression so much as a non-working new feature.

JelleZijlstra commented 10 months ago

Thanks, makes sense. So we'll just add the correct py.typed file the next time we touch those stubs.