search

typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI
Apache License 2.0
21 stars 16 forks source link

Add django-stubs, djangorestframework-stubs to allowlist #111

Closed intgr closed 2 months ago

intgr commented 11 months ago

Prerequisite for https://github.com/python/typeshed/pull/10919

Neither package appears in the PyPI top 1000 list. django-stubs is nr 1686 and djangorestframework-stubs is nr 2039.

But @sobolevn can vouch for the fact that these dependencies aren't evil :smiling_imp:

intgr commented 11 months ago

Actually this probably won't work because "we ensure that external dependencies of a stub package must be a dependency of the upstream package" (https://github.com/typeshed-internal/stub_uploader/issues/90#issue-1587077892). Pending further discussion in typeshed PR.

intgr commented 2 months ago

Thanks! I don't remember the details, but back when I opened this PR, it seemed to be blocked.

Did you take a look at the issue linked from https://github.com/typeshed-internal/stub_uploader/pull/111#issuecomment-1774072444 and it's no longer relevant?

AlexWaygood commented 2 months ago

Yeah, the stub-uploader tests are still failing on https://github.com/python/typeshed/pull/10919 despite this change, because of https://github.com/typeshed-internal/stub_uploader/pull/111#issuecomment-1774072444

intgr commented 2 months ago

Indeed, from job output https://github.com/python/typeshed/actions/runs/9940724727/job/27458123648?pr=10919

E stub_uploader.metadata.InvalidRequires: Expected dependency django-stubs to be listed in django-filter's requires_dist or the sdist's *.egg-info/requires.txt