search

typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI
Apache License 2.0
21 stars 16 forks source link

Add requests to EXTERNAL_REQ_ALLOWLIST #131

Closed kasium closed 5 months ago

kasium commented 5 months ago

Coming from https://github.com/typeshed-internal/stub_uploader/issues/90 it would be great to add requests to this list since it's needed to properly the recently added stubs for hvac. I guess it's a quite safe library to add (very common, no big dependencies beside urllib3, secure, ...)

AlexWaygood commented 5 months ago

requests doesn't ship with a py.typed file, so there wouldn't be much use adding it as a dependency for a stubs package. Can't you just add a dependency on types-requests instead (the stubs package typeshed distributes for requests)? Several of our other typeshed packages already do, e.g. https://github.com/python/typeshed/blob/db8e620e3db6eee13f70fbb6cfc90a851e4260c1/stubs/requests-oauthlib/METADATA.toml#L3

kasium commented 5 months ago

Valid point 😄