typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI
Apache License 2.0
21 stars 16 forks source link

Simplify type signature of collect_setup_entries #26

Closed nipunn1313 closed 3 years ago

nipunn1313 commented 3 years ago

Depends on #25

unfortunately, afaict, external contributors can't stack diffs and have github show the diff appropriately, since I can't set the base branch to #25. This diff will look more reasonable once #25 lands. In the meanwhile, you can just look the last commit on this PR.

If I were an internal contributor, I could set #25 as the base branch, but since the branch for #25 only exists in my fork, this doesn't work. Bunch of discussion about this here https://github.com/cli/cli/issues/2693