search

typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI
Apache License 2.0
21 stars 16 forks source link

Change versioning scheme to be more robust #57

Closed hauntsaninja closed 2 years ago

hauntsaninja commented 2 years ago

Currently sqlalchemy breaks typeshed CI basically whenever it releases a new micro version. This would allow us to pin sqlalchemy to a tighter version in METADATA.toml, while ensuring users who do pip install types-sqlalchemy will still get the latest stub.

Please see the comments in compute_incremented_version about what we attempt to guarantee (and the corresponding asserts in that function).

There's also some associated refactoring so that we can unit test logic easily and so that we can lean a little more heavily on packaging to do things for us.

hauntsaninja commented 2 years ago

Thanks for the review!!

hauntsaninja commented 2 years ago

Bump, I think I've made all requested changes + added more tests

srittau commented 2 years ago

I'm sorry, I have no time to review, but please merge if you and @JelleZijlstra are satisfied. And thanks for working on this!

JelleZijlstra commented 2 years ago

Merging since I'm not sure @hauntsaninja has merge access here.