typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI
Apache License 2.0
21 stars 16 forks source link

byte2int mypy annotations issue #75

Closed levincarmel closed 1 year ago

levincarmel commented 1 year ago

Hi, Starting 1.16.21.2 we have an issue with mypy failing for annotations of six.byte2int. We had this method:

def byte2int(c: Union[bytes, int]) -> int:
    if isinstance(c, bytes):
        return six.byte2int(c)
    return c

which was called the following way: pp_fingerprint = ":".join("{:02x}".format(byte2int(c)) for c in fingerprint).upper()

This used to work until now, but now we get this failure: Argument 1 to "byte2int" has incompatible type "bytes"; expected "SupportsGetItem[int, <nothing>]"

Is this an issue with this release? Or are we supposed to fix our annotations in some way?

Thanks in advance!

levincarmel commented 1 year ago

Opened in typeshed repo: https://github.com/python/typeshed/issues/9145