Closed srittau closed 1 year ago
Generally I like the idea, but I have one comment and I think it may be worth writing few unit tests for
_read_requirements()
.
Good idea, I will do so tomorrow.
typeshed is prepared now. I will add tests and switch to use packaging tomorrow.
Also, commit
should probably become part of TypeshedData
, but I will send a separate PR after this is merged to keep the changes minimal.
Cf. python/typeshed#6843