search

typestack / class-validator

Decorator-based property validation for classes.
MIT License
10.87k stars 786 forks source link

fix: IsUUID docs is outdated #2523

Open 4strodev opened 2 weeks ago

4strodev commented 2 weeks ago

Description

Internally it uses validator library and validator supports newer uuid versions. To avoid confusion, docs should be updated.

Expected behavior

Docs show that max supported uuid is v5.

Actual behavior

It actually supports uuid till v8

braaar commented 1 week ago

PR welcome!

4strodev commented 1 week ago

I will try to make a PR as soon as possible!. But from my experience in another repos I prefer to first make an issue and if the maintainers allow me then make a PR.

4strodev commented 1 week ago

After checking the dependencies on package.json and the releases of validatorjs. The support of uuid v8 is on master right now on validatorjs. The latest release 13.12. Has support for v1 to v7. Maybe an update could be a good idea. The problem here is that after updating the packages, the test suite fails. I could try to fix the bug. But I prefer to have green light before starting to make the PR.