typetools / checker-framework-inference

Inference of pluggable types for Java

10 stars 33 forks source link

Fix null location in VariableAnnotator#shallowAnnotateArray(). #57

Closed CharlesZ-Chen closed 7 years ago

CharlesZ-Chen commented 7 years ago

A fix to commit: https://github.com/typetools/checker-framework-inference/commit/923e3455816a9e434e385a0c6522294ef6da198d .

Original code in above commit might pass null location into method createEquivalentSlotConstraints(), which will cause a VariableAnnotation with null location generated. Also, this code will cause NullPointerException in the opprop version (when using updated slotManager to create VariableAnnotation.).

This PR change it from null to MISSING_LOCATION.

CharlesZ-Chen commented 7 years ago

The travis failure seems as same as the one in current master branch and not related to this PR. #55 should fix this failure.

wmdietl commented 7 years ago

@CharlesZ-Chen can you sync and see whether the travis failure goes away?

wmdietl commented 7 years ago

55 is merged, but master unfortunately still fails.

In #45 I'm getting a bit further, but for some strange reason a git usage fails. Do you have an idea what is going wrong? Feel free to push to #45 to test.

wmdietl commented 7 years ago

The latest version of #45 fixed the issues and I merged it. Pulling in master should fix this PR.

CharlesZ-Chen commented 7 years ago

Hi Prof. Dietl,

Sorry for the late response. I've synced this PR with master.

Best,

wmdietl commented 7 years ago

Thanks for the fix!