Fixes regression where composition is not enabled by default.

typewriter-editor / typewriter

A rich text editor based off of Quill.js and Ultradom, and using Svelte for UI.

MIT License

382 stars 32 forks source link

Fixes regression where composition is not enabled by default. #122

Open taylorhadden opened 1 year ago

taylorhadden commented 1 year ago

Not sure what happened here. What scenario/bug wants composition to be disabled?

Having composition disabled by default seems straight out incorrect; it causes terrible bugs with dictation, kanji composition, and the windows emoji picker.

The specific naming of setCompositionEnabled/allowComposition/enableComposition is whatever, but we should definitely have composition on by default.

taylorhadden commented 1 year ago

I missed the message at the bottom of #119 talking about GBoard. That sounds like a massive pain. I'm curious: if GBoard primarily works with composition, how does not handling composition work at all? I unfortunately do not have an android device to test with.

Is this a situation where we can detect GBoard and fall back to the less-than-ideal behavior?