I would like to propose to remove the explicit container_name and hostname fields for every service in the docker-compose.yml.
Why
it is not possible to run 2 docker-compose "swarms" on the same machine, since at least 2 services (polystore-api & ui) get the exact same container name, and this is not possible
the hostname & container_name are the same as the service name, so inside the compose network, the services should already be able to find each other just based on the service name
Impact
I've talked with @OrfenCLMS and he is sure the container_name can be dropped, but will report in this issue if hostname is also okay to be dropped.
MarieSaphira
commented
4 years ago
I would like to propose to remove the explicit
container_nameandhostnamefields for every service in thedocker-compose.yml.Why
Impact
I've talked with @OrfenCLMS and he is sure the
container_namecan be dropped, but will report in this issue ifhostnameis also okay to be dropped.