search

typhon-project / typhondl

http://www.typhon-project.org
Eclipse Public License 2.0
1 stars 0 forks source link

[BUG] DL model generation in presence of keyvalue database #45

Closed pinoval closed 4 years ago

pinoval commented 4 years ago

When trying to generate a DL model from the XMI representation of an ML model, there is an error stating "There is no template for a keyvaluedb".

image

MarieSaphira commented 4 years ago

Hi, go to Window -> Preferences -> TyphonDL -> DBTemplates -> Restore Defaults, same for DBType Templates. Sorry this should be done after every DL update, will put that information in the next PR as well.

pinoval commented 4 years ago

It still fails. It seems that there is no template for keyvalue or graph, even after clicking on Restore Defaults.

This is how that dialog looks like right after doing so:

Screen Shot 2020-06-09 at 16 06 50
MarieSaphira commented 4 years ago

That is weird, for now you can "Import" the templates. maybe delete the double ones. I will look into it

MarieSaphira commented 4 years ago

Sorry I don't seem to be able to reproduce that behavior, even if I delete all templates, all of them appear again if I click on Restore Defaults. The only difference I see is that I'm running eclipse 2020-03. Also this is an Xtext feature, what is your installed Xtext version?

pinoval commented 4 years ago

This is indeed strange. I followed your advice and imported the templates.xml file. After that, the preferences dialog looks like this:

Screen Shot 2020-06-09 at 17 04 44

Unfortunately, after generating the DL model, I got the same error and furthermore, the list of available templates on the preferences dialog reverted to the previous situation.

My Xtext version is 2.21.0.v20200302-1509.

MarieSaphira commented 4 years ago

The Xtext version is fine. Can you find anything in the Error Log?

MarieSaphira commented 4 years ago

Could you please post the content of <workspace>/.metadata/.plugins/org.eclipse.core.runtime/.settings/de.atb.typhondl.xtext.ui.prefs It should be

de.atb.typhondl.xtext.TyphonDL.templates=<?xml version\="1.0" encoding\="UTF-8" standalone\="no"?><templates/>
eclipse.preferences.version=1

And is this file changed when you import the templates and "apply"?

pinoval commented 4 years ago

This is the content, before "apply":

de.atb.typhondl.xtext.TyphonDL.templates=<?xml version\="1.0" encoding\="UTF-8" standalone\="no"?><templates/>
eclipse.preferences.version=1

The timestamp of the file does change when I import the templates and apply them, but the content remains the same.

MarieSaphira commented 4 years ago

ok, that means the plugin recognizes those as default templates. Sorry, I don't know why this is happening, could be something with the PersistentPreferenceStore of Eclipse. If other preference changes are correctly stored (e.g. change the line number color in General->Text Editors) maybe remove and reinstall the DL plugin.

pinoval commented 4 years ago

Apparently there were some problems with the deployment scripts. @DavyLandman tweaked them and now it is working again. I close therefore the issue.