typhon-project / typhondl

http://www.typhon-project.org
Eclipse Public License 2.0
1 stars 0 forks source link

[Feature] suggest default volumes for templated containers #66

Closed DavyLandman closed 4 years ago

DavyLandman commented 4 years ago

Is your feature request related to a problem? Please describe. Currently the DL wizard allows you to configure volume mounts, but by default none are defined. This means docker (and I'm guessing kubernetes) assign an anonymous volume to the volumes defined for the container.

Anonymous volumes are fine for development purposes (if you don't care about consistency of data across container restarts) but a lot less so for deployment purposes.

Describe the solution you'd like I would like to suggest we update the templates so that for the basic containers the wizard will at least ask the user to provide named (or locally mapped) volumes for the database containers.

I'm not suggesting we parse the dockerfile, (or the metadata inside the docker containers), just that we extend the templates a bit.

Describe alternatives you've considered It's possible to let the user handle this herself, but the rest of the DL wizard is quite supportive of making the right decisions (I think people will rarely find a need to customize the generate DL files). So I think it fits better with the design and user flow.

Additional context For example, mariadb should have a entry for: /var/lib/mysql and mongo likes to have a /data/db.