typhon-project / typhondl

http://www.typhon-project.org
Eclipse Public License 2.0
1 stars 0 forks source link

Add jar to flink #67

Closed MarieSaphira closed 4 years ago

MarieSaphira commented 4 years ago

Automatically uploads the jar-with-dependencies taken from here to the flink container

DavyLandman commented 4 years ago

Hi @MarieSaphira, @patrickneubauer and @zolotas4 it looks like you are building an on the fly container with a jar downloaded at a certain time. Which means that it's a bit unclear which version you are getting, and after version bumping your release, old docker configs are broken and won't follow along.

I would prefer if the analytics team would make a docker container for their jar, like all the other components in the polystore.

The easiest path is using jib, it integrates into maven, and both the qlserver and the polystore api already use it. If you want help setting it up, let me know.

DavyLandman commented 4 years ago

(if I should move this discussion to a different issue or slack, please let me know)

patrickneubauer commented 4 years ago

Hi @DavyLandman @zolotas4 @MarieSaphira
I added the jib plugin to the analytics pom.xml (this is in a feature branch) and found it to successfully deploy to a Docker Hub repository. Could this help?

DavyLandman commented 4 years ago

great!

MarieSaphira commented 4 years ago

@patrickneubauer could you publish the Docker Hub repository? It's not accessible without logging in.

EDIT: It's accessible here

MarieSaphira commented 4 years ago

@patrickneubauer so how does the jobmanager get to know about the analytics container?