search

typhon-project / typhonml

Eclipse Public License 2.0
6 stars 1 forks source link

Update `NlpTaskType` to revised NLP Type System #37

Closed Danny2097 closed 4 years ago

Danny2097 commented 4 years ago

When myself and @DrRaja joined the project we analysed the type system developed by the previous researcher. We discovered that it had some limitations particularly with extensibility. Since then we have updated it to address these limitations.

In ML these are represented as an enumeration. If we provide you essentially with a new list. Would it be possible for you to update the enumeration to reflect the changes?

@DrRaja - could you update the ML team with revised list of NlpTaskTypes?

@DavyLandman - Maybe also of interest for 'QL` as this relates to Issue #35

jdirocco commented 4 years ago

Please, let me know the new list of NLPTaskTypes, and I will change the metamodel and both graphical and textual editors. Moreover, I can change the NLPTaskType attribute type as a string. Even though the string type is more flexible, it allows the modeler to specify a wrong value. Let me know how you would like to define this field.

Danny2097 commented 4 years ago

I would suggest keeping the NLPTaskType as an enumeration. As we intended to expose an endpoint in our REST API were users can request the names of work flows for a specific NLPTasktype.

Danny2097 commented 4 years ago

We have made finalised the list of NLP tasks that Typhon should support.

We have removed EventExtraction (as this is considered as an instance of an already existing Task type) the others can be mapped.

This should also contribute towards the closure of issue #35

davidediruscio commented 4 years ago

Ok @Danny2097 we'll update ML accordingly.

Danny2097 commented 4 years ago

@davidediruscio Thank you.