typical-developers / oaklands-feedback

Give feedback about Oaklands!
2 stars 0 forks source link

[BUG]: terracotta refinery #670

Closed BladeeReal closed 3 months ago

BladeeReal commented 3 months ago

Roblox Username

medusabloodd

What version did this issue occur in?

1.60.0

Describe the issue in detail.

only some of my terracotta gets refined and the rest just passes through

Provide some images / videos of the issue in action.

https://github.com/typical-developers/oaklands-feedback/assets/174147392/58a2468b-ef8f-462d-8d63-de25727bb86a

Before Submitting

SniperOnSunday commented 3 months ago

Seems to happen a lot with the long/large stones. Happens with other rock types as well.

TRRESTGHGYTCFTGBCXSZD commented 3 months ago

The rocks are larger than acceptable size of refiner in 1 axis, but devs never fixed that. My solution is accept rock that dosen't exceed 2 axies, as it can fit in.

TRRESTGHGYTCFTGBCXSZD commented 3 months ago

The solution about this is:

function CheckIfTheHoleFits(Hole:Vector2,Size:Vector3)
    local LongestHoleSize = math.max(Hole.X,Hole.Y)
    local ShortestHoleSize = math.min(Hole.X,Hole.Y)
    local PartSizes = {Size.X,Size.Y,Size.Z}
    table.sort(PartSizes) -- needs optimization
    local LongestPartSize = PartSizes[3]
    local MiddlePartSize = PartSizes[2]
    local ShortestPartSize = PartSizes[1]
    return MiddlePartSize <= LongestHoleSize and ShortestPartSize <= ShortestHoleSize
end

As this works with rocks that are longer than 1 axis acceptable size. it rejects rocks exceeding acceptable size.

1Peekaboo1 commented 3 months ago

you're late изображение

The solution about this is:

function CheckIfTheHoleFits(Hole:Vector2,Size:Vector3)
  local LongestHoleSize = math.max(Hole.X,Hole.Y)
  local ShortestHoleSize = math.min(Hole.X,Hole.Y)
  local PartSizes = {Size.X,Size.Y,Size.Z}
  table.sort(PartSizes) -- needs optimization
  local LongestPartSize = PartSizes[3]
  local MiddlePartSize = PartSizes[2]
  local ShortestPartSize = PartSizes[1]
  return MiddlePartSize <= LongestHoleSize and ShortestPartSize <= ShortestHoleSize
end

As this works with rocks that are longer than 1 axis acceptable size. it rejects rocks exceeding acceptable size.

Somethingthatisnttakenplz commented 3 months ago

No shot he actually coded that