search

typicalzergling / vendor

Vendor WoW Addon
MIT License
4 stars 4 forks source link

Detect TBC classic as "classic" #54

Closed Rychard closed 3 years ago

Rychard commented 3 years ago

Prevent attempting to register the SCRAPPING_MACHINE_SHOW event in classic TBC.

I recognize that this change is rudimentary and overlooks any potential implications that may arise from treating "classic era" and "burning crusade classic" as having an identical API surface area (which of course is not the case)

typicalzergling commented 3 years ago

Does this change unblock Vendor classic to work reasonably well on TBC classic?

typicalzergling commented 3 years ago

Testing this out, along with the TOC changes, it looks like this is all that is required for TBC classic to function! Nice

Going to close this since I'm going to be making this change along with the TOC changes, thank you for this, as it saved me a bit of time looking it up!