search

typicode / hotel

🏩 A simple process manager for developers. Start apps from your browser and access them using local domains
MIT License
9.98k stars 422 forks source link

Use `please-upgrade-node` #206

Closed yeskunall closed 7 years ago

yeskunall commented 7 years ago

I didn't think tests were required, seeing as they don't exist already. Let me know if you think changes should be made.

Cheers! ❤️

typicode commented 7 years ago

Hi @yeskunall,

Thanks for this PR :) update-notifier should be kept as it's serving a different purpose than please-upgrade-node.

please-upgrade-node notifies that the version of Node doesn't match the one in engines and update-notifier notifies when a new version of hotel is released.

yeskunall commented 7 years ago

I'm sorry, @typicode, that's my bad. Can you please add a review to this PR so I can come back to it at a later time? Don't have the time to fix this at the very moment.

typicode commented 7 years ago

Done (I can do it too if you prefer, I have some free time now :))

yeskunall commented 7 years ago

I am back from work, making the requested changes right away! 👍

yeskunall commented 7 years ago

@typicode ping!

typicode commented 7 years ago

Thank you :)