search

typicode / hotel

🏩 A simple process manager for developers. Start apps from your browser and access them using local domains
MIT License
9.98k stars 424 forks source link

Change the frontend to React #242

Closed j-f1 closed 6 years ago

j-f1 commented 6 years ago

See also #241.

Plus a bunch of other things.

Checking out the commits individually might be more manageable — I’ve tried to make them fairly atomic (git rebase -i FTW!)

typicode commented 6 years ago

TBH I'm not used to PRs so big :/ Do you know how I could pick commits rather than the whole?

j-f1 commented 6 years ago

Do you know how I could pick commits rather than the whole?

Do you mean review them individually? If so, you can click on the “Changes from all commits” button on the files tab and show one commit at a time. Although the list of commits may look rather long, I’ve tried to make them clear and concise.

typicode commented 6 years ago

I would like to merge some parts of this PR. I was thinking of cherry-picking but I don't know if GitHub will retain the author of the code.

typicode commented 6 years ago

Hi @j-f1,

I've merged most of this PR commits (they can be found in the commits history). I've cherry-picked and rebased them the best I could (maybe not the most straightforward way).

As mentioned, on my side during the past weeks, I've done many tests and ended-up using quite a different stack/style (TypeScript, MobX and CSS grid/custom properties for the front).

Thanks again for exploring different ideas and for the bug fixes on the daemon 👍 :) !