Closed ghost closed 6 years ago
I am out of town right now. I will review this asap. Thanks for the commit.
Changes to English text LGTM. @stmitrophan please comment on the Chinese changes.
@stmitrophan Can you take a look at this please and OK the push? It's been languishing for almost a year!
Actually, these changes encompass only ASCII characters. A Chinese reviewer is not needed in this particular case.
The errors are missing pipe "|" symbols after certain verse numbers, and/or the letter "l" where there should have been a number "1" in a verse number, etc. (I'm guessing OCR artifacts or human typos). Other online copies of these texts have the same errors. In Ponomar, these are causing these specific Chinese chapters to fail to display.
On Wed, Aug 15, 2018 at 12:41 AM Aleksandr Andreev notifications@github.com wrote:
@stmitrophan https://github.com/stmitrophan Can you take a look at this please and OK the push? It's been languishing for almost a year!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/typiconman/ponomar/pull/16#issuecomment-412937407, or mute the thread https://github.com/notifications/unsubscribe-auth/ANMZrxZY6QOg-gdenNiavXNDt1FH6Knhks5uQv3LgaJpZM4P1TWe .
Merged. Thanks @mhs54321 for your contribution!