search

typiconman / ponomar

Ponomar: a liturgics suite for the Orthodox Church
http://www.ponomar.net/
GNU General Public License v3.0
37 stars 12 forks source link

automatic changes to fix unencoded att values #20

Closed pgmmpk closed 4 years ago

pgmmpk commented 4 years ago
  1. Fixed unescaped < and > in many Cmd attributes (automatically, with regex)
  2. Fixed invalid attribute name 2Stars by replacing with TwoStars in Services/Kathisma* (again, with regex)
pgmmpk commented 4 years ago

@typiconman please review. Escaping < and > are very safe. Re-naming attribute 2Stars->TwoStars is less so, but it seems that no code is using it anyways.

In any case, XML attribute can not start with a digit - these files will be rejected by most XML parses, unless fixed somehow.

For an example, see Ponomar/languages/xml/Services/Kathisma1.xml

typiconman commented 4 years ago

Yes, it's fine. Sorry, I didn't get around to it this morning.