search

typiconman / ponomar

Ponomar: a liturgics suite for the Orthodox Church
http://www.ponomar.net/
GNU General Public License v3.0
37 stars 12 forks source link

Duplicate Readings for the Sunday of the Forefathers (2 Sundays before Christmas) #58

Open mamyt opened 3 years ago

mamyt commented 3 years ago

Due to the way things are organised, the JAVA programme gives duplicate readings for the Sunday of the Forefathers. The problem needs to be verified that there are no further issues. I provided an easy fix.

typiconman commented 3 years ago

Can you be a bit more specific? Which XML files are offending?

mamyt commented 3 years ago

The files are languages/xml/9908.xml (which is the base file for the Sunday of the Forefathers) and the sequence of pentecostarion files for Sunday (e.g. languages/xml/{9232, 9239, 9246, 9253, 9260}.xml). When the combined in the JAVA version of the programme, the readings were invariably duplicated. I corrected it by commenting out in 9908.xml the readings. Now there is only a single set of readings.

On Wed, 30 Dec 2020 at 13:31, Aleksandr Andreev notifications@github.com wrote:

Can you be a bit more specific? Which XML files are offending?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/typiconman/ponomar/issues/58#issuecomment-752523426, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSMKOI2PDSFJKPELSY4DLLSXMMQNANCNFSM4VODLUIA .

typiconman commented 3 years ago

IIRC, 9908.xml is obsolete because the Perl API no longer uses "floaters".

mamyt commented 3 years ago

The file is still referenced in the individual pentecostarion files for creating the service on the given day. I will need to look into that and will give further information later. We got rid of floaters everywhere and replaced it by fixed files.

On Wed, 30 Dec 2020 at 15:40, Aleksandr Andreev notifications@github.com wrote:

IIRC, 9908.xml is obsolete because the Perl API no longer uses "floaters".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/typiconman/ponomar/issues/58#issuecomment-752644178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSMKOKKQ5NPWMYSYMPXTX3SXM3WTANCNFSM4VODLUIA .

mamyt commented 3 years ago

If you look in the file pentecostarion/253.xml, which states the commemorations to be observed on this particular Sunday, you will see that the listed commemorations are: 9902 (before Theophany), 9904 (after Christmas), 9906 (before Christmas), 9908 (of the Forefathers), and finally 9253 (the particular Sunday itself). If we specify the readings in both 9908 and 9253, which we used to, then we will have duplicate readings.

On Wed, 30 Dec 2020 at 15:40, Aleksandr Andreev notifications@github.com wrote:

IIRC, 9908.xml is obsolete because the Perl API no longer uses "floaters".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/typiconman/ponomar/issues/58#issuecomment-752644178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSMKOKKQ5NPWMYSYMPXTX3SXM3WTANCNFSM4VODLUIA .