Added custom elements v1.

typings / registry

The registry of type definitions for TypeScript

238 stars 176 forks source link

Closed turtlemay closed 7 years ago

turtlemay commented 7 years ago

Typings URL: https://github.com/turtlemay/typed-custom-elements-v1

Questions (for new typings):

[x] Does the README explain the purpose of the typings and have a link to the JavaScript project?
[x] Do the typings follow the source structure (e.g. index.js <-> index.d.ts)?
[x] Are they external or global modules according to the source (e.g. see README sources)?

Change Summary (for existing typings):

felixfbecker commented 7 years ago

Generally, versions should be done through branches (preferred) or subfolders

turtlemay commented 7 years ago

It's a browser spec so there is no semver and only one version, strictly speaking.

felixfbecker commented 7 years ago

Define the methods as methods instead of arrow function properties

felixfbecker commented 7 years ago

Otherwise LGTM