search

typings / registry

The registry of type definitions for TypeScript
238 stars 176 forks source link

Update graphql.json #964

Open ashleydw opened 7 years ago

ashleydw commented 7 years ago

Typings URL: https://github.com/nitintutlani/typed-graphql/

Change Summary (for existing typings):

There's no changelog available from the source repo, but looking at the commit history it is largely bug fixes with some additions.

blakeembrey commented 7 years ago

It looks like that module was changed to be a global definition in https://github.com/nitintutlani/typed-graphql/commit/b773a00569ac28d7d70793d9c46b7950628446c3. The commit alludes to "TypeScript 2.0" support, but I'm not sure the author understood what TypeScript 2.0 module resolution with NPM was since the change they made was definitely not required (TypeScript 2.0 just allows the NPM @types namespace which still uses external modules, module resolution that they added has existed in TypeScript since when Typings was released - since 1.5).

blakeembrey commented 7 years ago

It seems we should be able to bump this commit anytime you'd like now 😄

ashleydw commented 7 years ago

I've bumped the PR version up. If you can squash the merge that would save me starting a new PR :)

blakeembrey commented 7 years ago

@ashleydw Actually, I was wrong. Sorry, I only looked at the comment and not the code itself - it seems they didn't fix the issue and just moved stuff around instead (https://github.com/nitintutlani/typed-graphql/commit/6e0f3251cd51c52ea90fd691a951bdfa21f7f71a).