Rolling update for pvcs

typokign / matrix-chart

Helm chart for deploying a Matrix homeserver stack

MIT License

88 stars 47 forks source link

Rolling update for pvcs #35

Closed Routhinator closed 4 years ago

Routhinator commented 4 years ago

Add updateStrategy to ensure kubernetes knows it needs to unschedule the orginal deployment in order to release the ReadWriteOnce PVC on the bridges. Deployments in the chart currently fail when a bridge is in use because the old deployment is never stopped and the new deployment can never mount the ReadWriteOnce PVCs.

Fixes #34

typokign commented 4 years ago

Sorry for the delay, this looks good, thanks. I haven't run into the issue you're describing but I know DO is weird in many ways about PVCs.

mnaser commented 4 years ago

I'm not sure how this works, because I'm getting the following on Kubernetes 1.18:

error validating data: ValidationError(Deployment.spec): unknown field "updateStrategy" in io.k8s.api.apps.v1.DeploymentSpec

Routhinator commented 4 years ago

@mnaser there is already a PR and an Issue opened for this on 1.17+ - original change was tested on 1.16 which did not complain about the key error, even though it ignored it. See #37