typokign / matrix-chart

Helm chart for deploying a Matrix homeserver stack
MIT License
89 stars 48 forks source link

CoTURN - Automatically generated shared secret does not match between configurations #42

Open Arkaniad opened 4 years ago

Arkaniad commented 4 years ago

Summary

In the CoTURN subchart I noticed the following:

https://github.com/dacruz21/matrix-chart/blob/55dfb5b5c8f386bb3541aa27492e9cd07f611430/templates/coturn/_helpers.tpl#L1-L11

This randomly generated value seems to be generated twice if .Values.coturn.sharedSecret is left blank, which seems to prevent ICE candidates from being gathered properly.

If the shared secret is explicitly set in the values file, everything works and configuration matches as expected.

Steps to reproduce

Just run a helm install --dry-run --debug --namespace <test-namespace> <test-release-name> and pipe the output to less / bat / temporary file and check the shared secret values in homeserver.yaml and turnserver.conf - they will not match, and Coturn authentication will not work if deployed.