typora / typora-issues

Bugs, suggestions or free discussions about the minimal markdown editor — Typora
https://typora.io
1.53k stars 58 forks source link

Save File Failed bug #4617

Closed raffaeler closed 3 years ago

raffaeler commented 3 years ago

Describe the bug This started with the latest 0.11.5 version and I did never see it before.

The auto-save option is enabled, but I have no clue if this can impact or not.

After few hours of working, the auto-save tries to save the file and I get this dialog: image

The file is on the local disk and has been written multiple time in the previous hours. There is no predictable sequence of actions that lead to this outcome. I suspect some handle leak.

After I get this dialog, I am not able to save the file, so I copy the whole content in another application, then I have to cancel and close typora. At this point the file I was working on is zero bytes. It has been completely deleted. So I reopen it with typora and copy/paste the content from the other application. Now everything works again but also repeat again after few hours.

Expected behavior Documents are my assets, I expect them to be always saved.

Screenshots / Screencasts see above

Sample Markdown File It happened on multiple and very simple files. No special content outside text formatted with titles, bold and italics.

Desktop (please complete the following information):

Typora Version 0.11.5

guategeek commented 3 years ago

I also have had this happen twice now (but in my case saving using ctrl + s hotkey), also after a few hours of working, also with 0.11.5 on Windows 10 64bit, and I just checked and the "Auto Save" option is selected in the Preferences.

I unfortunately didn't copy the whole file out before closing, but only the changes I had made since the last successful save, so I lost about an hour and a half of work 😭

raffaeler commented 3 years ago

Sorry for that @guategeek , and thank you for confirming. This is a very bad and dangerous bug.

I am more and more convinced the cause may be a handle leak. Here is what I see in Process Explorer for Windows as time passes: image image image

Also, if I select the Typora process and see the handles, I can see the markdown file is opened hundreds of times, which doesn't make any sense. image

raffaeler commented 3 years ago

If someone is investigating on this, it may be worth taking a look to the registry keys as well: image

abnerlee commented 3 years ago

fixed in 0.11.6