typpo / google-charts-node

Render Google Charts to image
GNU Affero General Public License v3.0
35 stars 10 forks source link

puppeteer launch headless new #21

Open scottg369 opened 1 year ago

scottg369 commented 1 year ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch google-charts-node@2.0.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/google-charts-node/lib/render.js b/node_modules/google-charts-node/lib/render.js
index 0551607..21f4989 100644
--- a/node_modules/google-charts-node/lib/render.js
+++ b/node_modules/google-charts-node/lib/render.js
@@ -20,7 +20,7 @@ async function renderGoogleChart(contentRaw, optsRaw) {
     optsRaw || {},
   );

-  const browser = await puppeteer.launch(opts.puppeteerOptions);
+  const browser = await puppeteer.launch({headless: 'new'});

   const page = await browser.newPage();
   page.setDefaultTimeout(RENDER_TIMEOUT_MS);

This issue body was partially generated by patch-package.

typpo commented 1 year ago

Hi Scott,

This behavior is supported via puppeteerOptions. For example:

const image = await GoogleChartsNode.render(drawChart, {
  width: 400,
  height: 300,
  puppeteerOptions: {
    headless: 'new'
  }
});