typst-community / glossarium

Glossarium is a simple typst glossary.
MIT License
39 stars 11 forks source link

`group` gets printed regardless of if the term is used. #54

Closed TomVer99 closed 1 month ago

TomVer99 commented 2 months ago

The title is basically what the issue is.

If you have a term that is in a group, but that term is never used in the document the group heading still gets printed. This is an issue for me because I tend to have a single terms document in which I put all my project-related terms.

This issue also exists when there are multiple terms in a group, but none of those terms are used.

image

  (
    key: "unused",
    short: [UNUSED],
    long: [Unused],
    group: "unused"
  )
TomVer99 commented 2 months ago

Using glossarium version 0.4.1 from @preview

TomVer99 commented 2 months ago

Specifically in https://github.com/TomVer99/FHICT-typst-template/tree/main/examples/showcase. Template that is used is here: https://github.com/TomVer99/FHICT-typst-template/tree/main/template

TomVer99 commented 2 months ago

I saw there should be some logic to prevent this in

https://github.com/typst-community/glossarium/blob/f55d66d4b0189586817350817a6fc6fc8f5701c9/themes/default.typ#L743-L746

Is this also present in 0.4.1? Or just on the master branch for now?

quachpas commented 1 month ago

Hello @TomVer99, this feature is indeed present only in the master branch for now.

quachpas commented 1 month ago

@TomVer99 new release is out :)