Closed jamesrswift closed 5 months ago
Why was this merged if the tests fail?
EDIT: I notice now that it's not a test for dictionary
or either
, but the question remains for whatever caused this.
I think I was using the tests as a playground and forgot to fix (mb). Went in to fix (78a36ad7035cf2ad17758968fb7fdd1e4def216a and d138971629f1a3a8a6e80297898a68777abad4d9), and in so doing also fixed an unintended regression with ctx.remove-optional-none
which now works correctly once again.
strict
context parameter (defaulting to false) to check in all fields in given dictionary are present in the schema and vis versa (previously, it only checked if all the schema entries were present in the given dictionary)either
schema generator function now takes a parameterstrict
(defaulting to true) to set thestrict
context parameter on its children. This is a breaking change that fixes the bug you've brought upnone
. This is quite a big breaking change the package previously guaranteed that fields defined in schema would have keys defined in validated objects (even if that value wasnone
). I think doing it this way is better, but its still a big change so I won't merge until everyone has a good chance to test it out first.