typst-community / valkyrie

Type safe type safety for Typst
Other
33 stars 4 forks source link

Changes to `either` and `dictionary` #32

Closed jamesrswift closed 5 months ago

jamesrswift commented 5 months ago
tingerrr commented 5 months ago

Why was this merged if the tests fail?

EDIT: I notice now that it's not a test for dictionary or either, but the question remains for whatever caused this.

jamesrswift commented 5 months ago

I think I was using the tests as a playground and forgot to fix (mb). Went in to fix (78a36ad7035cf2ad17758968fb7fdd1e4def216a and d138971629f1a3a8a6e80297898a68777abad4d9), and in so doing also fixed an unintended regression with ctx.remove-optional-none which now works correctly once again.